Skip to content

Update Golang version to fix RIE debugging #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joe4dev merged 1 commit into from
Jan 27, 2026
Merged

Update Golang version to fix RIE debugging #74

joe4dev merged 1 commit into from
Jan 27, 2026

Conversation

@joe4dev
Copy link
Member

@joe4dev joe4dev commented Jan 27, 2026

@drauedo discovered a RIE debugging issue and fixed it by upgrading the Golang version 🙇‍♂️ 👏

@joe4dev joe4dev requested a review from drauedo January 27, 2026 10:26
@drauedo
Copy link

drauedo commented Jan 27, 2026

This lgmt 🚀

Some context of what happened:
Basically the make build command was failing with the following error:

cd .. && GC_FLAGS="all=-N -l" make ARCH=x86_64 compile-lambda-linux
make[1]: Entering directory '/home/eduardo/lambda-runtime-init'
CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -buildvcs=false -ldflags "" -gcflags="all=-N -l" -o bin/aws-lambda-rie-x86_64 ./cmd/localstack
make[1]: Leaving directory '/home/eduardo/lambda-runtime-init'
docker run --rm -v $(pwd)/build-delve/:/app/ golang:1.20-bullseye \
        bash -c "cd /app && export GOARCH=amd64 && ./build.sh"
Cloning into 'delve'...
pkg/logflags/logflags.go:10:2: package log/slog is not in GOROOT (/usr/local/go/src/log/slog)
note: imported by a module that requires go 1.24
make: *** [Makefile:10: build] Error 1
mv: cannot stat 'dlv': No such file or directory
make: *** [Makefile:32: build-delve/dlv] Error 1

I believe this was failing because I'm using go 1.25. Updating the image fixed the issue. However, I'm not sure if this is something we want to do.

gregfurman
gregfurman approved these changes Jan 27, 2026
View reviewed changes
Copy link

@gregfurman gregfurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! :shipit:

@joe4dev joe4dev merged commit f385253 into localstack Jan 27, 2026
2 checks passed
@joe4dev joe4dev deleted the update-golang-for-rie-debug branch January 27, 2026 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gregfurman gregfurman gregfurman approved these changes

@drauedo drauedo drauedo approved these changes

@dfangl dfangl Awaiting requested review from dfangl dfangl is a code owner

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joe4dev @drauedo @gregfurman